Ajout de la classe CMapHandlerGen #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Étienne Schmitt <[email protected]>
Signed-off-by: Étienne Schmitt <[email protected]>
Signed-off-by: Étienne Schmitt <[email protected]>
…graphhandler Signed-off-by: Étienne Schmitt <[email protected]>
This setting hides a useless warning message. Signed-off-by: Étienne Schmitt <[email protected]>
-added an enum CMapType containing all used map types. - added some pure virtual methodes in the CMapHandlerGen class : *type() const returne the CMapType of the MAP. * foreach_cell(Orbit, std::function) allowing to traverse the map without knowing its type.
Added setting "Auto enable on selected view" (enabled by default) Signed-off-by: Étienne Schmitt <[email protected]>
Signed-off-by: Étienne Schmitt <[email protected]>
Signed-off-by: Étienne Schmitt <[email protected]>
|
Ca me botte bien. Tout ce qui permet de supprimer du code est bienvenu et il y avait trop de code redondant là dedans.. |
|
Y'a un moyen de relancer la CI maintenant que la PR qu'il fallait a été mergé dans CGoGN ? |
|
Je l'avais relancé. Je le refais.
ld: symbol(s) not found for architecture x86_64`
|
|
Salut. Il y a un pb de symbole à corriger. Je m'en occupe demain.Le 19 mars 2019 17:39, Lionel Untereiner <[email protected]> a écrit :Je l'avais relancé. Je le refais
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
|
Signed-off-by: Étienne Schmitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salut,
Je propose dans cette PR la création d'une classe CMapHandlerGen.
Tout d'abord elle permet de réduire drastiquement la duplication de code. Ensuite elle facilite beaucoup les choses (notamment au sein du plugin attribute_editor).
Il devient maintenant possible de faire des traitements sans se soucier de la dimension de la carte.
J'ai aussi mis à jour la signature de plusieurs méthodes : utilisation des std::function qui présentent un surcoût négligeable (surtout dans les foreach_cellset par ex.) et autres joyeusetés.
J'attends vos retours sur ces modifs.
Etienne