-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SensorThings EDR Provider (USBR-115) #20
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I think the only thing I would call out would be ways to make it clearer long term / other contributors. But that's up to you
|
||
@BaseEDRProvider.register() | ||
def locations( | ||
self, select_properties=[], bbox=[], datetime_=None, location_id=None, **kwargs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it it is worth type annotating these to the extent we can just since it is sometimes not super clear what datatypes pygeoapi is passing to the provider. (i.e. datetime_
could be a datetime
object, string, if the client didn't know by experimenting etc.)
Co-authored-by: Colton Loftus <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Description
This PR implements SensorThingsAPI as an EDR provider for pygeoapi.
Changes Made
Related Issues
geopython/pygeoapi#1807
Additional Notes