Fix import in hello.go #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is improperly importing github.com/chai2010/gettext-go/ instead of github.com/chai2010/gettext-go/gettext Before the fix: $ go build hello.go hello.go:12:2: no buildable Go source files in /storage/gopath/src/github.com/chai2010/gettext-go After the fix: $ go build hello.go $ ./hello 你好, 世界! This is also causing golang/dep#170 since dep doesn't like importing the parent dir (not sure what's wrong with it though)
|
failing CI seems entirely unrelated. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is improperly importing github.com/chai2010/gettext-go/ instead of
github.com/chai2010/gettext-go/gettext
Before the fix:
$ go build hello.go
hello.go:12:2: no buildable Go source files in
/storage/gopath/src/github.com/chai2010/gettext-go
After the fix:
$ go build hello.go
$ ./hello
你好, 世界!
This is also causing golang/dep#170 since dep
doesn't like importing the parent dir (not sure what's wrong with it
though)