Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added type tags for number ranges. The tags only approximate the actual set of numbers. E.g. the types
0..100
and0..5 | 95..100
will both be displayed as0 ~ 100
. This simplification is necessary to display more complex number types, and I also think that the loss in information is okay. The bounds are the most important information (IMO) and those are still displayed correctly.Small sets of numbers will be displayed as is. E.g.
1 | int(98..100)
will be displayed as1 | 98 | 99 | 100
instead of as1 ~ 100
. This will only work for set with 4 or fewer numbers. So e.g.int(1..4)
will be displayed as1 | 2 | 3 | 4
, butint(1..5)
will be displayed as1 ~ 5
.Open questions:
1 | 3 | 4
) and a new range notation for ranges with tilde~
. Maybe we should use the type notations there as well? E.g.1..100
vs1 ~ 100
.