Merge pull request #993 from meeber/refactor-expect-types

refactor: `expectTypes` to access `ssfi` flag
chaijs · Jun 19, 2017 · 9116bc8 · 9116bc8
2 parents 351e968 + e7b2384
commit 9116bc8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/lib/chai/core/assertions.js b/lib/chai/core/assertions.js
@@ -462,7 +462,7 @@ module.exports = function (chai, _) {
   function include (val, msg) {
     if (msg) flag(this, 'message', msg);
 
-    _.expectTypes(this, ['array', 'object', 'string'], flag(this, 'ssfi'));
+    _.expectTypes(this, ['array', 'object', 'string']);
 
     var obj = flag(this, 'object')
       , objType = _.type(obj).toLowerCase()

diff --git a/lib/chai/utils/expectTypes.js b/lib/chai/utils/expectTypes.js
@@ -13,8 +13,6 @@
  *
  * @param {Mixed} obj constructed Assertion
  * @param {Array} type A list of allowed types for this assertion
- * @param {Function} ssfi starting point for removing implementation frames from
- *                        stack trace of AssertionError
  * @namespace Utils
  * @name expectTypes
  * @api public
@@ -24,8 +22,9 @@ var AssertionError = require('assertion-error');
 var flag = require('./flag');
 var type = require('type-detect');
 
-module.exports = function expectTypes(obj, types, ssfi) {
+module.exports = function expectTypes(obj, types) {
   var flagMsg = flag(obj, 'message');
+  var ssfi = flag(obj, 'ssfi');
 
   flagMsg = flagMsg ? flagMsg + ': ' : '';