Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Karma with Web Test Runner #1546

Merged
merged 10 commits into from
Oct 23, 2023
Merged

Conversation

koddsson
Copy link
Member

@koddsson koddsson commented Oct 21, 2023

Web Test Runner is a pretty good test runner that runs tests in browsers and a good replacement for Karma.

@koddsson koddsson requested a review from a team as a code owner October 21, 2023 19:53
@koddsson koddsson marked this pull request as draft October 21, 2023 19:53
@koddsson koddsson changed the title [WIP] Replacing Karma with Web Test Runner Replacing Karma with Web Test Runner Oct 21, 2023
package.json Outdated Show resolved Hide resolved
@koddsson
Copy link
Member Author

Looks like Safari has some nonstandard sourceURL property that's showing up in the AssertionError. Looking into this.

@koddsson
Copy link
Member Author

I actually just dropped checking in Safari. These issues also exist on branch 5.x.x but it looks like we've never tested in Safari before. Since WebKit uses a different standard than V8 we'd need to normalise the stack trace somehow but I'd say that it's out of scope for this work.

Reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/stack

@koddsson koddsson marked this pull request as ready for review October 23, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants