Tag and omit references to the refs file #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now tag and emit references for al arch imges to help external tools know what we've built (for example signing them). Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
mattmoor
approved these changes
Jul 16, 2022
Comment on lines
-246
to
-248
| // We only tag the images if we're building a single one | ||
| imageTags := []string{} | ||
| if len(bc.ImageConfiguration.Archs) == 1 { |
There was a problem hiding this comment.
I'm curious why we need this part of the change, or whether it regresses something 🤔
There was a problem hiding this comment.
Do you think it's better if I dont pass it to the tagging function and build the reference by hand? I did it because it was returning an empty string .
There was a problem hiding this comment.
I don't have enough context here, so I'd defer to @kaniini
There was a problem hiding this comment.
OK, I thought you had a specific problem in mind. I think we're fine, tests are ok and I've been using this branch today ok.
|
Once this lands, this downstream change will get pretty interesting 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now tag and emit references into the refs file for all arch images to help external
tools know what we've built (for example to sign them).
Closes: #288
/cc @mattmoor
Signed-off-by: Adolfo García Veytia (Puerco) [email protected]