feat: improve local include #996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpcalisi
force-pushed
the
feature/extend-include
branch
from
df629f7
to
63ea46a
Compare
lpcalisi
force-pushed
the
feature/extend-include
branch
from
63ea46a
to
379b6f2
Compare
lpcalisi
force-pushed
the
feature/extend-include
branch
from
379b6f2
to
6629081
Compare
lpcalisi
changed the title
lpcalisi
force-pushed
the
feature/extend-include
branch
from
6629081
to
eebc036
Compare
imjasonh
approved these changes
Jan 15, 2024
|
@imjasonh shall you review it? |
imjasonh
approved these changes
Feb 1, 2024
|
@imjasonh one more please |
imjasonh
approved these changes
Feb 1, 2024
|
@imjasonh any comments? do you think about? |
|
@imjasonh could you give feedback about it please? |
Signed-off-by: Lucas Pablo Calisi <[email protected]>
- add tests - include accounts, paths, environment. Signed-off-by: Lucas Pablo Calisi <[email protected]>
Signed-off-by: Lucas Pablo Calisi <[email protected]>
Signed-off-by: Lucas Pablo Calisi <[email protected]>
lpcalisi
force-pushed
the
feature/extend-include
branch
from
4ef499c
to
30c9a3b
Compare
|
@imjasonh Do you think this still makes sense? This PR was here for the last tree months |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includein apko file now supports merge configurations for accounts, environments and path mutations.related #1008