Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test_movie_review.py #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shenganzhang
Copy link

This PR aims to improve the reliability of the test test_movie_review.py by changing the encoding method in chazutsu/datasets/framework/resource.py, so that the reading function won't run into error when reading .
The error can be reproduced when running for multiple times. E.g.
touch run.py and with in this python file write:
import os
for i in range(100): os.system('pytest tests/test_movie_review.py >> repeat_100_result.log')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant