Enable es6toprimitive under experimental #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Microsoft/chakra-es could you take look pls? |
nit: (not related to your change) this assert should be moved below if check and its body. If this result is nullptr then this assert will throw, isn't it? #Closed Refers to: lib/Runtime/Language/JavascriptConversion.cpp:528 in bf450f4. [](commit_id = bf450f4, deletion_comment = False) |
| assert.areEqual(Symbol.toStringTag, Symbol.toStringTag[Symbol.toPrimitive](), "Symbol.toStringTag"); | ||
| assert.areEqual(Symbol.unscopables, Symbol.unscopables[Symbol.toPrimitive](), "Symbol.unscopables"); | ||
|
|
||
| assert.throws(()=>Symbol.prototype[Symbol.toPrimitive].call(undefined), TypeError, "undefined", "Symbol[Symbol.toPrimitive]: 'this' is not a Symbol object"); |
There was a problem hiding this comment.
these are duplicated? same tests are there in the es6symbol.js, aren't they?
There was a problem hiding this comment.
Enable es6toprimitive under experimental flag. Update following areas to be spec-compliant: ToPrimitive (abstract operation) Date.prototype[@@toprimitive]() Symbol.prototype[@@toprimitive]() Update unit tests with coverage on: ToNumber (abstract operation) ToString (abstract operation) ToPropertyKey (abstract operation) Abstract rational comparison (abstract operation) Abstract equality comparison (abstract operation) + operator Date() constructor Date.prototype.toJSON()
|
|
chakrabot
pushed a commit
that referenced
this pull request
Jul 26, 2016
Merge pull request #1319 from suwc:build/suwc/buddy Enable es6toprimitive under experimental flag. Update following areas to be spec-compliant: ToPrimitive (abstract operation) Date.prototype[@@toprimitive]() Symbol.prototype[@@toprimitive]() Update unit tests with coverage on: ToNumber (abstract operation) ToString (abstract operation) ToPropertyKey (abstract operation) Abstract rational comparison (abstract operation) Abstract equality comparison (abstract operation) "+" operator Date() constructor Date.prototype.toJSON()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable es6toprimitive under experimental flag.
Update following areas to be spec-compliant:
ToPrimitive (abstract operation)
Date.prototype@@toprimitive
Symbol.prototype@@toprimitive
Update unit tests with coverage on:
ToNumber (abstract operation)
ToString (abstract operation)
ToPropertyKey (abstract operation)
Abstract rational comparison (abstract operation)
Abstract equality comparison (abstract operation)
"+" operator
Date() constructor
Date.prototype.toJSON()