Extend return register lifetime #3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter(s) then remove it in FinalLower. Fixing a bug in wasm int64 returns on x86 where edx is reused to reload a spilled value for eax.
|
|
chakrabot
pushed a commit
that referenced
this pull request
Jun 29, 2017
Merge pull request #3264 from Cellule:users/micfer/ret Keep the `Ret` instruction to extend the lifetime of the return register(s) then remove it in FinalLower. Fixing a bug in wasm int64 returns on x86 where edx is reused to reload a spilled value for eax. Fixes [OSG 12195427](https://microsoft.visualstudio.com/os/_workitems?id=12195427)
chakrabot
pushed a commit
that referenced
this pull request
Jun 29, 2017
Merge pull request #3264 from Cellule:users/micfer/ret Keep the `Ret` instruction to extend the lifetime of the return register(s) then remove it in FinalLower. Fixing a bug in wasm int64 returns on x86 where edx is reused to reload a spilled value for eax. Fixes [OSG 12195427](https://microsoft.visualstudio.com/os/_workitems?id=12195427)
sigatrev
added a commit
to sigatrev/ChakraCore
that referenced
this pull request
Dec 12, 2017
PRs chakra-core#3019, chakra-core#3264, and chakra-core#3509. These occured after the point where the ARM64 starting point was forked.
sigatrev
added a commit
to sigatrev/ChakraCore
that referenced
this pull request
Dec 12, 2017
PRs chakra-core#3019, chakra-core#3264, and chakra-core#3509. These occured after the point where the ARM64 starting point was forked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the
Retinstruction to extend the lifetime of the return register(s) then remove it in FinalLower.Fixing a bug in wasm int64 returns on x86 where edx is reused to reload a spilled value for eax.
Fixes OSG 12195427
This change is