Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsrt: JsObject Delete/Get/Has/OwnP../Set Property #3875

Merged
merged 2 commits into from
Nov 6, 2017
Merged

jsrt: JsObject Delete/Get/Has/OwnP../Set Property #3875

merged 2 commits into from
Nov 6, 2017

Commits on Nov 6, 2017

  1. fix native-shared python test file (non-CI use)

    @obastemur
    obastemur committed Nov 6, 2017
    Configuration menu
    Copy the full SHA
    718f271 View commit details
    Browse the repository at this point in the history

  2. jsrt: JsObject Delete/Get/Has/OwnP../Set Property 

    AcmeAIR LTO gain (3%)

New JSRT property interface that API user can use without going through
convert-to-property-id process.

See # 3790 for details.

Also added a TODO note;
```
TODO: Can we make PropertyString && LiteralStringWithPropertyStringPtr
share the string buffer?
```

Once this PR is merged, there will be an additional PR on
node-chakracore end to benefit this new interface.
    @obastemur
    obastemur committed Nov 6, 2017
    Configuration menu
    Copy the full SHA
    fc6240e View commit details
    Browse the repository at this point in the history