Skip to content

Commit

Permalink
Disable chokidar polling override in tests
Browse files Browse the repository at this point in the history
Ran into bugs/issues with using polling mode when writing tests for embroider-build#1696, specifically that on my macOS dev environment using polling, when watching a directory it doesn't seem to consistently emit the `added` event. 

Mainly I wanted to see which, if any, tests fail without this option. It also seemed a bit suspect since rollup/chokidar presumably works on windows out of the box? 

Even if this is necessary we may want to limit it to the windows test only (can just set `CHOKIDAR_USEPOLLING` on the job level), since this makes things _less_ realistic everywhere else.
  • Loading branch information
chancancode authored Dec 5, 2023
1 parent 3480aa6 commit a562b4e
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions tests/scenarios/helpers/v2-addon.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,6 @@ export class DevWatcher {
configFile.options.map((options: RollupOptions) => {
options.watch = {
buildDelay: 20,
// Windows doesn't have a good file-watching mechanism (such as inotify),
// so we need to tell this `DevWatcher` tool to use chokidar's polling feature
chokidar: {
usePolling: true,
},
};
return options;
})
Expand Down

0 comments on commit a562b4e

Please sign in to comment.