Remove EPHIN msids and facilitate arc and snapshot decoupling #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william-aaron-CFA
approved these changes
Dec 19, 2023
william-aaron-CFA
approved these changes
Jan 2, 2024
malgosias
changed the title
malgosias
changed the title
taldcroft
reviewed
Feb 8, 2024
| } | ||
| } | ||
|
|
||
| $new_hash{$msid} = {'time' => $h{$msid}[0], |
There was a problem hiding this comment.
Output this time as a string in the standard YYYY:DOY:HH:MM:SS.sss format so there is no ambiguity in interpretation by downstream apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes 3 MSIDs related to EPHIN temperature from the snap display: "Ephin Temp", "EIO Temp", "Eph temp", and adds a functionality to write Chandra snapshot in the json format to remove Replan Central dependency on the chandra.snapshot layout changes.
Affected files:
snap_format.pm,tlogr_linux.pl. The new layout can be inspected on BUOCC Snapshot on luke-v. The code change was tested on old telemetry and produced the followingchandra.snapshotlayout differences:...Pitch Mom. 2.251 SCS 132 ACT Warm Rad -79.6
Yaw Mom. -17.247 SCS 133 ACT RadMon ENAB
PMTANKP 118.159 SCS 107 INAC
...
to be compared with
...Pitch Mom. 2.251 SCS 132 ACT Ephin Temp 0.0000 Warm Rad -79.6
Yaw Mom. -17.247 SCS 133 ACT EIO Temp 0.0000 RadMon ENAB
PMTANKP 118.159 SCS 107 INAC EPH temp 115.28
...
The
chandra.snapshot.jsonfile is formatted as follows:{MSID1: {"time": ..., "value": ..., "status": ...}, MSID2: {"time": ..., "value": ..., "status": ...}, ...}