Skip to content

Commit

Permalink
Set minute to wildcard in renovate schedule (#2405)
Browse files Browse the repository at this point in the history
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue

<!-- Please link to issue if one exists -->

<!-- Fixes #0000 -->
- #1217


## Summary

<!-- Please brief explanation of the changes made -->

- renovate schedule에서 minute을 * 으로 변경합니다. 

## Details

<!-- Please elaborate description of the changes -->

- 위 이슈에서 `Invalid schedule: "0 10-19 1-7 * MON" has cron syntax, but
doesn't have * as minutes` 에러를 뱉고 있습니다.

소스를 뒤져보면 


```tsx
      if (
        parsedCron.fields.minute.length !== 60 ||
        scheduleText.indexOf(minutesChar) !== 0 // (const minutesChar = "*")
      ) {
        message = `Invalid schedule: "${scheduleText}" has cron syntax, but doesn't have * as minutes`;
        return true;
      }
```

cron syntax에서는 minute 이 * 이어야 하는 것 같습니다. 

### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->

- No

## References

<!-- Please list any other resources or points the reviewer should be
aware of -->

-
https://github.com/renovatebot/renovate/blob/64b0555ce303f83a566765a0fa092a1ea4c22a48/lib/workers/repository/update/branch/schedule.ts#L61-L67
  • Loading branch information
yangwooseong authored Aug 5, 2024
1 parent 9d7e8bf commit 91a0dd1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["config:base", ":labels(chore:deps)"],
"timezone": "Asia/Seoul",
"schedule": "0 10-19 1-7 * MON",
"schedule": "* 10-19 1-7 * MON",
"packageRules": [
{
"groupName": "style",
Expand Down

0 comments on commit 91a0dd1

Please sign in to comment.