-
Notifications
You must be signed in to change notification settings - Fork 47
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(bezier-tokens): fix scoping issues with common semantic tokens (#…
…1910) <!-- How to write a good PR title: - Follow [the Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/). - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [x] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Related Issue <!-- Please link to issue if one exists --> - #1779 ## Summary <!-- Please brief explanation of the changes made --> Fix scoping issues with common semantic tokens ## Details <!-- Please elaborate description of the changes --> <img width="886" alt="image" src="https://github.com/channel-io/bezier-react/assets/58209009/a159ab9e-ceca-4f18-9eff-b1a715ce0330"> > 우측 라이트 테마의 box-shadow가 다크 테마의 box-shadow(shdw 컬러) 토큰을 참조한 모습 - #1779 에서 공용 시맨틱 토큰을 줄이고자, CSS의 경우 전체 루트 선택자 하위에만 variable을 선언했습니다. - 예상과 다르게 실제는 가장 가까운 테마의 시맨틱 토큰을 참조하는 게 아니라, 루트에 적용된 시맨틱 토큰을 참조하는 방식으로 동작했습니다. - #1779 이전으로 되돌려, 각 테마별 스코프에 공용 시맨틱 토큰을 (중복되더라도) 각각 선언하여 참조가 올바르게 되도록 변경했습니다. ### Breaking change? (Yes/No) <!-- If Yes, please describe the impact and migration path for users --> No (alpha)
- Loading branch information
1 parent
4f0e6eb
commit d23b739
Showing
1 changed file
with
58 additions
and
107 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters