You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
smoothCornersScript throws error when called twice.
Reproduction process
smoothcorners를 사용하는 BezierProvider 를 2번 이상 호출하는 경우, 사용처에서 Uncaught DOMException: Failed to execute 'registerPaint' on 'PaintWorkletGlobalScope': A class with name:'smooth-corners' is already registered. 에러가 뜨게 됩니다. try catch 로 묶어서 error 가 뜨지않도록 하면 좋겠습니다.
Version of bezier-react
1.20.0
Browser
No response
Operating system
macOS
Windows
Linux
Additonal Information
No response
The text was updated successfully, but these errors were encountered:
… twice (#2010)
<!--
How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
- Give as much context as necessary and as little as possible
- Prefix it with [WIP] while it’s a work in progress
-->
## Self Checklist
- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
- Windows: Chrome, Edge, (Optional) Firefox
- macOS: Chrome, Edge, Safari, (Optional) Firefox
## Related Issue
<!-- Please link to issue if one exists -->
- fixes#2002
<!-- Fixes #0000 -->
## Summary
<!-- Please brief explanation of the changes made -->
Add `try catch` block to mute the error when `smoothCornerScript` is
called twice.
## Details
<!-- Please elaborate description of the changes -->
According to the [MDN documentation on
`registerPaint()`](https://developer.mozilla.org/en-US/docs/Web/API/PaintWorkletGlobalScope/registerPaint#exceptions),
this function only throws two errors. One when the parameters aren't
met, throwing `TypeError` and the other when a worklet already exists
with the given name, throwing `DOMException`. I thought that any of
those two case won't happen in this particular case, so I just no-oped
the `catch` statement. If it is not a good approach, I can narrow the
error down to the later one, `DOMException`.
### Breaking change? (Yes/No)
<!-- If Yes, please describe the impact and migration path for users -->
No.
## References
<!-- Please list any other resources or points the reviewer should be
aware of -->
https://developer.mozilla.org/en-US/docs/Web/API/PaintWorkletGlobalScope/registerPaint#exceptions
Summary
smoothCornersScript
throws error when called twice.Reproduction process
smoothcorners를 사용하는 BezierProvider 를 2번 이상 호출하는 경우, 사용처에서 Uncaught DOMException: Failed to execute 'registerPaint' on 'PaintWorkletGlobalScope': A class with name:'smooth-corners' is already registered. 에러가 뜨게 됩니다. try catch 로 묶어서 error 가 뜨지않도록 하면 좋겠습니다.
Version of bezier-react
1.20.0
Browser
No response
Operating system
Additonal Information
No response
The text was updated successfully, but these errors were encountered: