-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert enum type of component props to string literal type - Toast, Tooltip, etc #1990
Convert enum type of component props to string literal type - Toast, Tooltip, etc #1990
Conversation
…` enum to string literal
…use" This reverts commit c7530b9.
🦋 Changeset detectedLatest commit: 297b174 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chromatic Report🚀 Congratulations! Your build was successful! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## alpha #1990 +/- ##
==========================================
- Coverage 84.04% 83.99% -0.06%
==========================================
Files 134 121 -13
Lines 2250 2199 -51
Branches 606 605 -1
==========================================
- Hits 1891 1847 -44
+ Misses 282 276 -6
+ Partials 77 76 -1 ☔ View full report in Codecov by Sentry. |
IconSize: { | ||
XL: 'xl', | ||
L: 'l', | ||
Normal: 'normal', | ||
S: 's', | ||
XS: 'xs', | ||
XXS: 'xxs', | ||
XXXS: 'xxxs', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utils/story
path 로 검색해보면 타입스크립트 설정 등에서 이 유틸을 빌드 아티팩트에서 제외하기 위한 코드가 있을거에요. 이 부분도 함께 제거되어야할 거 같습니다.
Self Checklist
Related Issue
Summary
Details
IconSize
의 경우IconSize.Normal = 24
와 같이 size value 를 그대로 사용하던 것을'normal'
을 받고 컴포넌트 내부에서 size 로 맵핑하는 형식으로 변경했습니다. number literal 을 그대로 받는 것보다 이렇게 하는 게 다른 컴포넌트와의 일관성이 유지된다고 생각하였습니다.TextAreaHeight
enum 은TextAreaHeight.Row16
처럼 쓰이고 있어서 이를'row16'
으로 바꾸는 것보다는16
으로 받는게 깔끔한 것 같아서 예외적으로 number literal 을 받도록 했습니다.Breaking change? (Yes/No)
References