Convert enum type of component props to string literal type - Toast, Tooltip, etc #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` enum to string literal
…use" This reverts commit c7530b9.
🦋 Changeset detectedLatest commit: 297b174 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yangwooseong
added
enhancement
Chromatic Report🚀 Congratulations! Your build was successful! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## alpha #1990 +/- ##
==========================================
- Coverage 84.04% 83.99% -0.06%
==========================================
Files 134 121 -13
Lines 2250 2199 -51
Branches 606 605 -1
==========================================
- Hits 1891 1847 -44
+ Misses 282 276 -6
+ Partials 77 76 -1 ☔ View full report in Codecov by Sentry. |
sungik-choi
reviewed
Feb 13, 2024
Comment on lines
226
to
233
| IconSize: { | ||
| XL: 'xl', | ||
| L: 'l', | ||
| Normal: 'normal', | ||
| S: 's', | ||
| XS: 'xs', | ||
| XXS: 'xxs', | ||
| XXXS: 'xxxs', |
There was a problem hiding this comment.
이번 기회에 피그마와 동일하게 m 으로 맞추면 좋을 거 같아요
There was a problem hiding this comment.
utils/story path 로 검색해보면 타입스크립트 설정 등에서 이 유틸을 빌드 아티팩트에서 제외하기 위한 코드가 있을거에요. 이 부분도 함께 제거되어야할 거 같습니다.
sungik-choi
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
Related Issue
Summary
Details
IconSize의 경우IconSize.Normal = 24와 같이 size value 를 그대로 사용하던 것을'normal'을 받고 컴포넌트 내부에서 size 로 맵핑하는 형식으로 변경했습니다. number literal 을 그대로 받는 것보다 이렇게 하는 게 다른 컴포넌트와의 일관성이 유지된다고 생각하였습니다.TextAreaHeightenum 은TextAreaHeight.Row16처럼 쓰이고 있어서 이를'row16'으로 바꾸는 것보다는16으로 받는게 깔끔한 것 같아서 예외적으로 number literal 을 받도록 했습니다.Breaking change? (Yes/No)
References