Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Storybook 8 #2309

Merged
merged 8 commits into from
Jul 2, 2024
Merged

Upgrade to Storybook 8 #2309

merged 8 commits into from
Jul 2, 2024

Conversation

yangwooseong
Copy link
Collaborator

@yangwooseong yangwooseong commented Jun 27, 2024 •
edited
Loading

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

  • Storybook 버전을 8로 올리고 breaking change에 대응합니다.

Details

Breaking change? (Yes/No)

  • No

References

@yangwooseong yangwooseong added chore:system Issue or PR regarding source environment (e.g. lints, tests), not the actual source code dependencies Pull requests that update a dependency file (Dependabot) labels Jun 27, 2024
@yangwooseong yangwooseong self-assigned this Jun 27, 2024
@channeltalk ChannelTalk
Copy link

channeltalk bot commented Jun 27, 2024

https://desk.channel.io/#/channels/1/team_chats/groups/1237/667d00be3f6a672032f3

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a6bae0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 27, 2024 •
edited
Loading

Chromatic Report

🚀 Congratulations! Your build was successful!

@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (b523b08) to head (a6bae0a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2309   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         140      140           
  Lines        2919     2919           
  Branches      892      879   -13     
=======================================
  Hits         2448     2448           
  Misses        466      466           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yangwooseong
yangwooseong commented Jun 27, 2024
View reviewed changes
packages/bezier-react/package.json
@@ -110,6 +110,7 @@
"rollup-plugin-postcss": "^4.0.2",
"rollup-plugin-visualizer": "^5.12.0",
"sass": "^1.71.1",
"sass-loader": "^14.2.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addon-styling 에 sass-loader 의존성이 포함되어 있어서 addon-styling를 지우고 addon-styling-webpack만 설치하면 scss 를 읽지 못하는 에러가 뜹니다.

@yangwooseong yangwooseong marked this pull request as ready for review June 27, 2024 07:33
sungik-choi
sungik-choi approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@sungik-choi sungik-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 docgen 에러 고쳐진 거 좋네요

@yangwooseong
feat(storybook): automatic upgrade to 8
6dc5217 
- `npx storybook@latest upgrade`
@yangwooseong
feat(storybook): disable autodocs in stories which has docs
61963ad 
- see https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#mainjs-docsautodocs-is-deprecated
@yangwooseong
feat(storybook): migrate mdx
3230bd6 
- Story -> Canvas (it shows code), id -> of, ArgsTables -> ArgTypes
- see https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#mdx-related-changes
@yangwooseong
feat(storybook): rm unnecessary addon
54c7a7b
@yangwooseong
feat(storybook): replace @storybook/addon-styling with @storybook/add…
b4b7a3d 
…on-styling-webpack

- @storybook/addon-styling is deprecated
- https://github.com/storybookjs/addon-styling/blob/main/MIGRATION.md
@yangwooseong
chore: remove storybook specific versioning in .syncpackrc
acea89f
@yangwooseong
feat(storybook): resolve type error
5badce4
@yangwooseong
chore: resolve unused vars warning
a6bae0a
@yangwooseong yangwooseong merged commit c161dca into channel-io:main Jul 2, 2024
9 checks passed
@yangwooseong yangwooseong deleted the WEB-2268/storybook-version branch July 2, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungik-choi sungik-choi sungik-choi approved these changes

Assignees

@yangwooseong yangwooseong

Labels
chore:system Issue or PR regarding source environment (e.g. lints, tests), not the actual source code dependencies Pull requests that update a dependency file (Dependabot)
Projects
Bezier React
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore Storybook 8
2 participants
@yangwooseong @sungik-choi