fix(cli): improve reporter message (biomejs#3186)

CHANGELOG.md

@@ -19,6 +19,21 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 ### CLI
 
+#### Enhancement
+
+- Reword the reporter message `No fixes needed` to `No fixes applied`.
+
+  The former message is misleading when there're still errors or warnings in the files that should be taken care of manually. For example:
+
+  ```block
+  Checked 2 files in <TIME>. No fixes needed.
+  Found 2 errors.
+  ```
+
+  The new message suits better in these cases.
+
+  Contributed by @Sec-ant
+
 ### Configuration
 
 ### Editors

crates/biome_cli/src/reporter/terminal.rs

@@ -93,7 +93,7 @@ impl fmt::Display for SummaryDetail {
             })
         } else {
             fmt.write_markup(markup! {
-                " No fixes needed."
+                " No fixes applied."
             })
         }
     }

crates/biome_cli/tests/snapshots/main_cases_biome_json_support/always_disable_trailing_commas_biome_json.snap

@@ -21,5 +21,5 @@ expression: content
 # Emitted Messages
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_biome_json_support/biome_json_is_not_ignored.snap

@@ -28,5 +28,5 @@ expression: content
 # Emitted Messages
 
 ```block
-Checked 2 files in <TIME>. No fixes needed.
+Checked 2 files in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_biome_json_support/ci_biome_json.snap

@@ -21,5 +21,5 @@ expression: content
 # Emitted Messages
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_biome_json_support/linter_biome_json.snap

@@ -35,5 +35,5 @@ internalError/fs  DEPRECATED  ━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_config_extends/extends_config_ok_formatter_no_linter.snap

@@ -53,6 +53,6 @@ test.js format ━━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_config_extends/extends_config_ok_linter_not_formatter.snap

@@ -78,7 +78,7 @@ test.js format ━━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 Found 1 warning.
 ```

crates/biome_cli/tests/snapshots/main_cases_config_extends/extends_resolves_when_using_config_path.snap

@@ -68,6 +68,6 @@ test.js format ━━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 2 errors.
 ```

crates/biome_cli/tests/snapshots/main_cases_config_path/set_config_path_to_directory.snap

@@ -55,6 +55,6 @@ src/index.js format ━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_config_path/set_config_path_to_file.snap

@@ -55,6 +55,6 @@ src/index.js format ━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_cts_files/should_allow_using_export_statements.snap

@@ -11,5 +11,5 @@ export default { cjs: true };
 # Emitted Messages
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_diagnostics/diagnostic_level.snap

@@ -54,6 +54,6 @@ src/index.js organizeImports ━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_diagnostics/logs_the_appropriate_messages_according_to_set_diagnostics_level.snap

@@ -28,5 +28,5 @@ debugger;
 # Emitted Messages
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_diagnostics/max_diagnostics_no_verbose.snap

@@ -34,6 +34,6 @@ src/file.js format ━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_diagnostics/max_diagnostics_verbose.snap

@@ -130,6 +130,6 @@ src/folder_0/package-lock.json project  VERBOSE  ━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_editorconfig/should_have_biome_override_editorconfig.snap

@@ -34,5 +34,5 @@ console.log(
 # Emitted Messages
 
 ```block
-Formatted 1 file in <TIME>. No fixes needed.
+Formatted 1 file in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_astro_files/astro_global.snap

@@ -14,5 +14,5 @@ const { some } = Astro.props
 # Emitted Messages
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_astro_files/does_not_throw_parse_error_for_return.snap

@@ -18,5 +18,5 @@ if (foo) {
 # Emitted Messages
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_astro_files/format_astro_carriage_return_line_feed_files.snap

@@ -39,6 +39,6 @@ file.astro format ━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_astro_files/format_astro_files.snap

@@ -46,6 +46,6 @@ file.astro format ━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_astro_files/format_empty_astro_files_write.snap

@@ -11,5 +11,5 @@ expression: content
 # Emitted Messages
 
 ```block
-Formatted 1 file in <TIME>. No fixes needed.
+Formatted 1 file in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_astro_files/lint_astro_files.snap

@@ -44,6 +44,6 @@ file.astro:2:1 lint/suspicious/noDebugger  FIXABLE  ━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_astro_files/sorts_imports_check.snap

@@ -42,6 +42,6 @@ file.astro organizeImports ━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_css_files/should_format_files_by_when_opt_in.snap

@@ -35,6 +35,6 @@ input.css format ━━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_css_files/should_lint_files_by_when_enabled.snap

@@ -43,6 +43,6 @@ input.css:1:6 lint/nursery/noEmptyBlock ━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_css_files/should_not_format_files_by_default.snap

@@ -22,5 +22,5 @@ internalError/io ━━━━━━━━━━━━━━━━━━━━━
 # Emitted Messages
 
 ```block
-Checked 0 files in <TIME>. No fixes needed.
+Checked 0 files in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_css_files/should_not_lint_files_by_default.snap

@@ -30,5 +30,5 @@ internalError/io ━━━━━━━━━━━━━━━━━━━━━
 # Emitted Messages
 
 ```block
-Checked 0 files in <TIME>. No fixes needed.
+Checked 0 files in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_svelte_files/format_svelte_carriage_return_line_feed_files.snap

@@ -39,6 +39,6 @@ file.svelte format ━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_svelte_files/format_svelte_ts_context_module_files.snap

@@ -42,6 +42,6 @@ file.svelte format ━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_svelte_files/sorts_imports_check.snap

@@ -42,6 +42,6 @@ file.svelte organizeImports ━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/format_empty_vue_js_files_write.snap

@@ -11,5 +11,5 @@ expression: content
 # Emitted Messages
 
 ```block
-Formatted 1 file in <TIME>. No fixes needed.
+Formatted 1 file in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/format_empty_vue_ts_files_write.snap

@@ -11,5 +11,5 @@ expression: content
 # Emitted Messages
 
 ```block
-Formatted 1 file in <TIME>. No fixes needed.
+Formatted 1 file in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/format_vue_carriage_return_line_feed_files.snap

@@ -39,6 +39,6 @@ file.vue format ━━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/format_vue_explicit_js_files.snap

@@ -42,6 +42,6 @@ file.vue format ━━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/format_vue_generic_component_files.snap

@@ -37,6 +37,6 @@ file.vue format ━━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/format_vue_implicit_js_files.snap

@@ -42,6 +42,6 @@ file.vue format ━━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/format_vue_ts_files.snap

@@ -42,6 +42,6 @@ file.vue format ━━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/lint_vue_js_files.snap

@@ -102,6 +102,6 @@ file.vue:4:1 lint/style/noVar  FIXABLE  ━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 3 errors.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/lint_vue_ts_files.snap

@@ -124,6 +124,6 @@ file.vue:4:1 lint/style/noVar  FIXABLE  ━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 4 errors.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/sorts_imports_check.snap

@@ -42,6 +42,6 @@ file.vue organizeImports ━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/vue_compiler_macros_as_globals.snap

@@ -58,6 +58,6 @@ file.vue:16:36 lint/suspicious/noExplicitAny ━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_overrides_linter/does_not_change_linting_settings.snap

@@ -40,5 +40,5 @@ internalError/fs  DEPRECATED  ━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 2 files in <TIME>. No fixes needed.
+Checked 2 files in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_overrides_linter/does_preserve_group_recommended_when_override_global_recommened.snap

@@ -49,5 +49,5 @@ internalError/fs  DEPRECATED  ━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 3 files in <TIME>. No fixes needed.
+Checked 3 files in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_overrides_linter/does_preserve_individually_diabled_rules_in_overrides.snap

@@ -49,5 +49,5 @@ internalError/fs  DEPRECATED  ━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 3 files in <TIME>. No fixes needed.
+Checked 3 files in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_protected_files/not_process_file_from_cli.snap

@@ -22,5 +22,5 @@ internalError/io ━━━━━━━━━━━━━━━━━━━━━
 # Emitted Messages
 
 ```block
-Checked 0 files in <TIME>. No fixes needed.
+Checked 0 files in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_protected_files/not_process_file_from_cli_verbose.snap

@@ -34,5 +34,5 @@ package-lock.json project  VERBOSE  ━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 0 files in <TIME>. No fixes needed.
+Checked 0 files in <TIME>. No fixes applied.
 ```

crates/biome_cli/tests/snapshots/main_cases_protected_files/not_process_file_linter_disabled_from_cli_verbose.snap

@@ -46,6 +46,6 @@ other.json format ━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_protected_files/not_process_ignored_file_from_cli_verbose.snap

@@ -46,6 +46,6 @@ other.json format ━━━━━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Checked 1 file in <TIME>. No fixes needed.
+Checked 1 file in <TIME>. No fixes applied.
 Found 1 error.
 ```

crates/biome_cli/tests/snapshots/main_cases_reporter_summary/reports_diagnostics_summary_check_command.snap

@@ -87,6 +87,6 @@ lint/suspicious/noDebugger                              8 (8 error(s), 0 warning
 ```
 
 ```block
-Checked 2 files in <TIME>. No fixes needed.
+Checked 2 files in <TIME>. No fixes applied.
 Found 44 errors.
 ```