-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TissueMapper ontology should match Dataset schema ontology version #355
Comments
@brianraymor @atolopko-czi since this tissue mapper is a copy of the tissue mapper in the portal we probably want to address this sequentially.
What is the tracking issue for the portal equivalent? I was trying to find but was out of luck. I will add it as a dependency to this issue once I have it. |
I need to decide how to model these issues within an epic. I think it should be included in the discovery plan for ontology-only updates. @pablo-gar Didn't you open an earlier issue - feat: Develop system to maintain Gene Expression's Tissue Mapper class in sync with pinned UBERON ontology of h5ad schema? |
I'll stay tuned for the model, and yes I opened that ticket requesting to create such model. I will add it as dependency here, thanks! |
Alec added this issue yesterday |
Motivation
The builder's UBERON (tissue) ontology obtains the ontology file directly from the 3rd party source, but is always the latest version available. This may be ahead of the version referenced in the Dataset Schema version. The ontology file should be obtained from the Dataset Schema's "latest" UBERON version listed in https://raw.githubusercontent.com/chanzuckerberg/single-cell-curation/main/cellxgene_schema_cli/cellxgene_schema/ontology_files/owl_info.yml.
Definition of Done
TissueMapper uses the same uberon ontology owl file as is used by the validation tool for a given Dataset Schema major version
Tasks
The text was updated successfully, but these errors were encountered: