Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TissueMapper ontology should match Dataset schema ontology version #355

Closed
2 tasks done
atolopko-czi opened this issue Apr 5, 2023 · 4 comments · Fixed by #388
Closed
2 tasks done

TissueMapper ontology should match Dataset schema ontology version #355

atolopko-czi opened this issue Apr 5, 2023 · 4 comments · Fixed by #388
Assignees
Labels
census builder Related to the census builder tool tech

Comments

@atolopko-czi
Copy link
Collaborator

atolopko-czi commented Apr 5, 2023

Motivation

The builder's UBERON (tissue) ontology obtains the ontology file directly from the 3rd party source, but is always the latest version available. This may be ahead of the version referenced in the Dataset Schema version. The ontology file should be obtained from the Dataset Schema's "latest" UBERON version listed in https://raw.githubusercontent.com/chanzuckerberg/single-cell-curation/main/cellxgene_schema_cli/cellxgene_schema/ontology_files/owl_info.yml.

Definition of Done

TissueMapper uses the same uberon ontology owl file as is used by the validation tool for a given Dataset Schema major version

Tasks

@metakuni metakuni added the census builder Related to the census builder tool label Apr 5, 2023
@pablo-gar pablo-gar added the P0 Priority 0 - Critical, fix ASAP! label Apr 5, 2023
@pablo-gar
Copy link
Contributor

pablo-gar commented Apr 6, 2023

@brianraymor @atolopko-czi since this tissue mapper is a copy of the tissue mapper in the portal we probably want to address this sequentially.

  1. Update the tissue mapper in portal.
  2. Copy updated mapper to this repo.

What is the tracking issue for the portal equivalent? I was trying to find but was out of luck. I will add it as a dependency to this issue once I have it.

@brianraymor
Copy link

I need to decide how to model these issues within an epic. I think it should be included in the discovery plan for ontology-only updates.

@pablo-gar Didn't you open an earlier issue - feat: Develop system to maintain Gene Expression's Tissue Mapper class in sync with pinned UBERON ontology of h5ad schema?

@pablo-gar
Copy link
Contributor

pablo-gar commented Apr 6, 2023

I'll stay tuned for the model, and yes I opened that ticket requesting to create such model. I will add it as dependency here, thanks!

@atolopko-czi
Copy link
Collaborator Author

atolopko-czi commented Apr 7, 2023

What is the tracking issue for the portal equivalent?

Alec added this issue yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
census builder Related to the census builder tool tech
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants