Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin uberon ontology version #388

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

atolopko-czi
Copy link
Collaborator

@atolopko-czi atolopko-czi commented Apr 18, 2023

Fixes #355

Testing is just unit tests, but these load the real ontology file, so should be sufficient.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #388 (17f884b) into main (8f7af94) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   88.33%   88.34%           
=======================================
  Files          50       50           
  Lines        2727     2728    +1     
=======================================
+ Hits         2409     2410    +1     
  Misses        318      318           
Flag Coverage Δ
unittests 88.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/cellxgene_census_builder/build_soma/globals.py 100.00% <100.00%> (ø)
...llxgene_census_builder/build_soma/tissue_mapper.py 84.81% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atolopko-czi atolopko-czi changed the title fix: pin uberon ontology version chore: pin uberon ontology version Apr 18, 2023
Copy link

@brianraymor brianraymor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uberon release version is correct.

@atolopko-czi atolopko-czi merged commit 7771f30 into main Apr 20, 2023
@atolopko-czi atolopko-czi deleted the atol/355-tissuemapper-ontology-version branch April 20, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TissueMapper ontology should match Dataset schema ontology version
3 participants