Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New embeddings API notebooks #1070

Merged
merged 23 commits into from
Apr 2, 2024
Merged

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Mar 29, 2024

Notebooks for the new embedding API usage.

Notebook 1 preview
Notebook 2 preview

Notes:

  1. I removed the Loading embeddings into a Scipy matrices and NumPy arrays part from Notebook 1, and I replaced it with Load an embedding into a dense NumPy array. Using sparse matrices isn't straightforward with the new API, since we don't expose direct access to the underlying SparseNDArray, and I don't think the example was particularly useful in the first place, since all the embeddings we have are essentially dense.
  2. This PR also contains the docsite changes for the new convenience methods.

@ebezzi ebezzi force-pushed the ebezzi/new-embeddings-api-notebooks branch from 1b5a86d to 3c057c2 Compare March 29, 2024 22:14
@ebezzi ebezzi force-pushed the ebezzi/new-embeddings-api-notebooks branch from 3c057c2 to ed60d43 Compare March 29, 2024 22:21
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.34%. Comparing base (c6cf312) to head (deb2dbf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1070   +/-   ##
=======================================
  Coverage   82.34%   82.34%           
=======================================
  Files          74       74           
  Lines        5714     5714           
=======================================
  Hits         4705     4705           
  Misses       1009     1009           
Flag Coverage Δ
unittests 82.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ebezzi ebezzi marked this pull request as ready for review April 1, 2024 16:27
Base automatically changed from ebezzi/new-embeddings-api to main April 1, 2024 22:15
Copy link
Contributor

@atarashansky atarashansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Copy link
Contributor

@pablo-gar pablo-gar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can you please fix this small item before merging?

  • Delete the last empty cell for api/python/notebooks/api_demo/census_access_maintained_embeddings.ipynb

@ebezzi ebezzi merged commit bee224d into main Apr 2, 2024
15 checks passed
@ebezzi ebezzi deleted the ebezzi/new-embeddings-api-notebooks branch April 2, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants