-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New embeddings API notebooks #1070
Conversation
1b5a86d
to
3c057c2
Compare
3c057c2
to
ed60d43
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
=======================================
Coverage 82.34% 82.34%
=======================================
Files 74 74
Lines 5714 5714
=======================================
Hits 4705 4705
Misses 1009 1009
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, can you please fix this small item before merging?
- Delete the last empty cell for
api/python/notebooks/api_demo/census_access_maintained_embeddings.ipynb
Notebooks for the new embedding API usage.
Notebook 1 preview
Notebook 2 preview
Notes:
Loading embeddings into a Scipy matrices and NumPy arrays
part from Notebook 1, and I replaced it withLoad an embedding into a dense NumPy array
. Using sparse matrices isn't straightforward with the new API, since we don't expose direct access to the underlying SparseNDArray, and I don't think the example was particularly useful in the first place, since all the embeddings we have are essentially dense.