-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Follow spec-0 #1189
[python] Follow spec-0 #1189
Conversation
Not positive it's entirely related but we had a hard fail on MacOS, beyond our control: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1189 +/- ##
==========================================
+ Coverage 91.19% 91.21% +0.02%
==========================================
Files 77 79 +2
Lines 5971 6146 +175
==========================================
+ Hits 5445 5606 +161
- Misses 526 540 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I've gone ahead and made a few changes here. Right now I've followed spec-0, but since we can't do 3.12 while tiledbsoma pins it I've just left off support there. My last commit is just letting the formatter run + a couple manual fixes. I can revert it if other changes are needed. |
This is ready for review. I think the main question is whether we want to drop support for python 3.8 and 3.9 if we can't support 3.12 while tiledbsoma pins it. |
This PR has not seen any activity in the past 4 weeks; if no one comments or reviews it in the next 3 days, this PR will be closed. |
no |
This reverts commit fc7aefe.
Fixes #1177
This PR implements adoption SPEC-0 for support windows of dependencies.
I'm going to hold off on running formatting for all files until I'm done with the manual changes to make this readable.
Blocked by tiledbsoma's pinning of pyarrow to v12 (current release is v16). It looks like it's difficult to install
pyarrow~=12.0
on python 3.12 since there haven't been any wheel releases. See: single-cell-data/TileDB-SOMA#1926