[builder] Add collection_doi_label to the datasets dataframe #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebezzi
changed the title
prathapsridharan
requested changes
Jun 21, 2024
| @@ -90,6 +90,7 @@ def load_manifest_from_CxG() -> list[Dataset]: | |||
| collection_id=dataset["collection_id"], | |||
| collection_name=null_to_empty_str(dataset["collection_name"]), | |||
| collection_doi=null_to_empty_str(dataset["collection_doi"]), | |||
| collection_doi_label=null_to_empty_str(dataset.get("collection_doi_label")), | |||
There was a problem hiding this comment.
Here you are using dataset.get("...") which does simply returns None if the key doesn't exist - that is, it does not raise an exception. The other calls use dataset["..."] which raise on exception if the key doesn't exist.
Should this semantics be made consistent? Maybe the other key lookups in null_to_empty_str() should use dataset.get(...) instead?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1200 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 77 77
Lines 5922 5923 +1
=======================================
+ Hits 5396 5397 +1
Misses 526 526
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
prathapsridharan
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1180