Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fix ExperimentDataPipe length #1221

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Jul 3, 2024

Fixes #1183

@ebezzi ebezzi requested a review from ivirshup July 3, 2024 17:43
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.26%. Comparing base (f775282) to head (75dc638).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1221      +/-   ##
==========================================
+ Coverage   91.19%   91.26%   +0.07%     
==========================================
  Files          77       79       +2     
  Lines        5971     6148     +177     
==========================================
+ Hits         5445     5611     +166     
- Misses        526      537      +11     
Flag Coverage Δ
unittests 91.26% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ebezzi ebezzi merged commit af88f3d into main Jul 8, 2024
15 checks passed
@ebezzi ebezzi deleted the ebezzi/fix-datapipe-length branch July 8, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior when getting length of ExperimentDatapipe
2 participants