Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarifies text for Feature Dataset Presence Matrix, rename schema file #211

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

pablo-gar
Copy link
Contributor

Changes:

  • Clarifies 'Feature Dataset Presence Matrix' specification, it was recently noted by @atolopko-czi that the spec was ambiguous and text was added to clarify it
  • The schema minor version is bumped.
  • Removes version number from schema file to reduce maintenance cost of other docs referring to it.

…rsion from schema file to reduce maintance cost of other docs referring to it
@pablo-gar pablo-gar marked this pull request as ready for review February 22, 2023 01:46
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #211 (23fded7) into main (61b655d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   82.43%   82.43%           
=======================================
  Files          28       28           
  Lines        1560     1560           
=======================================
  Hits         1286     1286           
  Misses        274      274           
Flag Coverage Δ
unittests 82.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablo-gar pablo-gar merged commit 902d4a8 into main Feb 22, 2023
@pablo-gar pablo-gar deleted the pablo-gar/schema-minor-fix branch February 22, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants