add unit tests for python cell_census package #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #244 +/- ##
==========================================
+ Coverage 83.92% 85.07% +1.15%
==========================================
Files 29 29
Lines 1642 1682 +40
==========================================
+ Hits 1378 1431 +53
+ Misses 264 251 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added 2 commits
March 6, 2023 13:44
bkmartinjr
changed the title
ebezzi
approved these changes
Mar 6, 2023
|
|
||
| @pytest.mark.live_corpus | ||
| def test_download_source_h5ad(tmp_path: pathlib.Path, small_dataset_id: str) -> None: | ||
| # with cell_census.open_soma(census_version="latest") as census: |
There was a problem hiding this comment.
Can the commented code be removed?
There was a problem hiding this comment.
oops! Yes, definitely.
| @@ -60,6 +63,11 @@ def test_get_census_version_directory(directory_mock: Any) -> None: | |||
| assert directory[tag] == cell_census.get_census_version_description(tag) | |||
|
|
|||
|
|
|||
| def test_get_census_version_description_errors() -> None: | |||
| with pytest.raises(KeyError): | |||
There was a problem hiding this comment.
Not strictly related to the tests, but I was wondering if maybe we don't want to specialize these exceptions? Right now everything is KeyError or ValueError but these exceptions map to very specific issues (for instance, non existent census version.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes - more/better unit tests for the cell_census python package:
open_somaand other APIopen_somaparametersuri_join