improved build workflow

.github/workflows/py-build.yml

@@ -2,8 +2,9 @@ name: Python cell_census build
 
 on:
   pull_request:
-    paths-ignore:
-      - "api/r/**"
+    paths:
+      - "api/python/**"
+      - "tools/cell_census_builder/**"
   push:
     branches: [main]
   workflow_dispatch:
@@ -34,3 +35,28 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           path: api/python/cell_census/dist/*
+
+  build_docker_container:
+    name: Build Docker image for Census Builder
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+
+      - uses: actions/setup-python@v4
+        with:
+          python-version: "3.10"
+
+      - name: Install deps
+        run: |
+          python -m pip install -U pip setuptools build
+
+      - name: Build package
+        run: python -m build
+        working-directory: tools/cell_census_builder/
+
+      - name: Build image
+        run: docker build --build-arg=COMMIT_SHA=$(git rev-parse --short HEAD) -t cell-census-builder .
+        working-directory: tools/cell_census_builder/

.github/workflows/py-unittests.yml

@@ -53,8 +53,8 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install -U pip setuptools wheel
-          pip install -r ./tools/scripts/requirements.txt -r ./tools/scripts/requirements-dev.txt
-          pip install -e ./tools/
+          pip install -e ./tools/cell_census_builder/
+          pip install -r ./tools/scripts/requirements-dev.txt
       - name: Test with pytest (builder)
         run: |
           PYTHONPATH=. coverage run --parallel-mode -m pytest ./tools/cell_census_builder/tests/

.pre-commit-config.yaml

@@ -54,3 +54,4 @@ repos:
           - numpy
           - typing_extensions
           - types-setuptools
+          - types-PyYAML

tools/cell_census_builder/Dockerfile

@@ -0,0 +1,18 @@
+FROM ubuntu:22.04
+
+ENV DEBIAN_FRONTEND=noninteractive
+
+ARG COMMIT_SHA
+ENV COMMIT_SHA=${COMMIT_SHA}
+
+RUN apt update && apt -y full-upgrade && apt -y install python3.10-venv python3-pip awscli
+
+ADD entrypoint.sh /
+ADD dist/ /tools/cell_census_builder
+
+RUN python3 -m pip install -U pip Cython wheel build
+RUN python3 -m pip install /tools/cell_census_builder/*.whl
+
+WORKDIR /census-build
+
+ENTRYPOINT ["/bin/bash", "/entrypoint.sh"]

tools/cell_census_builder/Makefile

@@ -0,0 +1,10 @@
+# Build docker image. This Makefile is for developer convenience.
+
+.PHONY: image
+image: clean
+	python3 -m build .
+	docker build --build-arg=COMMIT_SHA=$(git rev-parse --short HEAD) -t cell-census-builder .
+
+.PHONY: clean
+clean:
+	rm -rf build dist

tools/cell_census_builder/README.md

@@ -1,16 +1,103 @@
 # README
 
-This is a tool to build the SOMA instantiation of the Cell Census schema, as specified in this doc:
+This package contains code to build and release the Cell Census in the SOMA format, as specified in the
+[data schema](https://github.com/chanzuckerberg/cell-census/blob/main/docs/cell_census_schema.md).
 
-https://docs.google.com/document/d/1GKndzCk9q_1SdYOq3BeCxWgp-o2NSQkEmSBaBPKnNI8/
+This tool is not intended for end-users - it is used by the CELLxGENE team to periodically create and release all
+CELLxGENE data in the above format. The remainder of this document is intended for users of the
+build package.
 
-CAVEATS (READ THIS):
+Please see the top-level [README](../../README.md) for more information on the Cell Census and
+using the Cell Census data.
 
-1. The code is written to the still-rapidly-evolving and **pre-release** Python SOMA API, _and will be subject to change_ as the SOMA API and `tiledbsoma` evolve and stabilize.
-2. The schema implemented by this code is still evolving and subject to change.
-3. The `cell_census_builder` package requires Python 3.9 or later.
+## Overview
 
-## Usage
+This package contains sub-modules, each of which automate elements of the Cell Census build and release process.
+They are wrapped at the package top-level by by a `__main__` which implements the Cell Census build process,
+with standard defaults.
+
+The top-level build can be invoked as follows:
+
+- Create a working directory, e.g., `census-build` or equivalent.
+- If any configuration defaults need to be overridden, create a `config.yaml` in the working directory containing the default overrides. _NOTE:_ by default you do not need to create a `config.yaml` file -- the defaults are appropriate to build the full Census.
+- Run the build as `python -m cell_census_builder your-working_dir`
+
+This will perform four steps (more will be added the future):
+
+- host validation
+- build soma
+- validate soma
+- build reports (eg., summary)
+
+This will result in the following file tree:
+
+```
+working_dir:
+    |
+    +-- config.yaml        # build config (user provided, read-only)
+    +-- state.yaml         # build runtime state (eg., census version tag, etc)
+    +-- build-version      # defaults to current date, e.g., 2023-01-20
+    |   +-- soma
+    |   +-- h5ads
+    +-- logs               # log files from various stages
+    |   +-- build.log
+    |   +-- ...
+    +-- reports
+        +-- census-summary-VERSION.txt
+        +-- census-diff-VERSION.txt
+```
+
+## Building and using the Docker container
+
+The standard Census build is expected to be done via a Docker container. To build the required image, do a `git pull` to the version you want to use, and do the following to create a docker image called `cell-census-builder`:
+
+```
+$ cd tools/cell_census_builder
+$ make image
+```
+
+To use the container to build the _full_ census, with default options, pick a working directory (e.g., /tmp/census-build), and:
+
+```
+$ mkdir /tmp/census-build
+$ chmod ug+s /tmp/census-build   # optional, but makes permissions handling simpler
+$ docker run --mount type=bind,source="`pwd`/tmp/census-build",target='/census-build' cell-census-builder
+```
+
+### Build configuration options
+
+This is primarily for the use of package developers. The defaults are suitable for the standad Census build, and are defined in the `build_state.py` file.
+
+If you need to override a default, create `config.yaml` in the build working directory and specify the overrides. An example `config.yaml` might look like:
+
+```
+verbose: 2  # debug level logging
+consolidate: false  # disable TileDB consolidation
+```
+
+### Commands to cleanup local Docker state on your ec2 instance (while building an image)
+
+Docker keeps around intermediate layers/images and if your machine doesn't have enough memory, you might run into issues. You can blow away these cached layers/images by running the following commands.
+
+```
+docker system prune
+docker rm -f $(docker ps -aq)
+docker rmi -f $(docker images -q)
+```
+
+## Module-specific notes
+
+### `host_validation` module
+
+Module which provides a set of checks that the current host machine has the requisite capabilities
+to build the census (e.g., free disk space). Raises exception (non-zero process exit) if host is
+unable to meet base requirements.
+
+Stand-alone usage: `python -m cell_census_builder.host_validation`
+
+### `build_soma` module
+
+Stand-alone use: `python -m cell_census_builder.build_soma ...`
 
 TL;DR:
 
@@ -25,26 +112,26 @@ The build process:
 - Step 3: Write the axis dataframes for each experiment, filtering the datasets and cells to include (serialized iteration of dataset H5ADs).
 - Step 4: Write the X layers for each experiment (parallelized iteration of filtered dataset H5ADs).
 - Step 5: Write datasets manifest and summary info.
-- (Optional) Consolidate TileDB data 
+- (Optional) Consolidate TileDB data
 - (Optional) Validate the entire Cell Census, re-reading from storage.
 
 Modes of operation:
 a) (default) creating the entire "cell census" using all files currently in the CELLxGENE repository.
 b) creating a smaller "cell census" from a user-provided list of files (a "manifest")
 
-### Mode (a) - creating the full cell census from the entire CELLxGENE (public) corpus:
+#### Mode (a) - creating the full cell census from the entire CELLxGENE (public) corpus:
 
 - On a large-memory machine with _ample_ free (local) disk (eg, 3/4 TB or more) and swap (1 TB or more)
 - To create a cell census at `<census_path>`, execute:
   > $ python -m cell_census_builder -mp --max-workers 12 <census_path> build
-- Tips: 
-    - `-v` to view info-level logging during run, or `-v -v` for debug-level logging
-    - `--test-first-n <#>` to test build on a subset of datasets
-    - `--build-tag $(date +'%Y%m%d_%H%M%S')` to produce non-conflicting census build directories during testing
+- Tips:
+  - `-v` to view info-level logging during run, or `-v -v` for debug-level logging
+  - `--test-first-n <#>` to test build on a subset of datasets
+  - `--build-tag $(date +'%Y%m%d_%H%M%S')` to produce non-conflicting census build directories during testing
 
 If you run out of memory, reduce `--max-workers`. You can also try a higher number if you have lots of CPU & memory.
 
-### Mode (b) - creating a cell census from a user-provided list of H5AD files:
+#### Mode (b) - creating a cell census from a user-provided list of H5AD files:
 
 - Create a manifest file, in CSV format, containing two columns: dataset_id, h5ad_uri. Example:
   ```csv
@@ -55,15 +142,3 @@ If you run out of memory, reduce `--max-workers`. You can also try a higher numb
   You can specify a file system path or a URI in the second field
 - To create a cell census at `<census_path>`, execute:
   > $ python -m cell_census_builder <census_path> build --manifest <the_manifest_file.csv>
-
-### Other info
-
-There are more options discoverable via the `--help` command line option.
-
-Note on required host resources:
-
-- all H5AD files not on the local disk will be downloaded/cached locally. There must be
-  sufficient local file system space. Location of cache can be controlled with the
-  environment variable `FSSPEC_CACHE_DIR`
-- each H5AD will be read into memory, in its entirety. Sufficient RAM must be present to
-  allow for this (and to do so for multiple H5ADs concurrently if you use the `--multi-process` option)

tools/cell_census_builder/entrypoint.sh

@@ -0,0 +1,3 @@
+#!/bin/bash
+
+python3 -m cell_census_builder .

tools/cell_census_builder/pyproject.toml

@@ -0,0 +1,72 @@
+[build-system]
+requires = ["setuptools>=45", "setuptools_scm[toml]>=6.2"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "cell_census_builder"
+dynamic = ["version"]
+description = "Build Cell Census"
+authors = [
+    { name = "Chan Zuckerberg Initiative", email = "[email protected]" }
+]
+license = { text = "MIT" }
+readme = "README.md"
+requires-python = ">= 3.9, < 3.11"  # Python 3.11 is pending numba support
+classifiers = [
+    "Development Status :: 2 - Pre-Alpha",
+    "Intended Audience :: Developers",
+    "Intended Audience :: Information Technology",
+    "Intended Audience :: Science/Research",
+    "License :: OSI Approved :: MIT License",
+    "Programming Language :: Python",
+    "Topic :: Scientific/Engineering :: Bio-Informatics",
+    "Operating System :: POSIX :: Linux",
+    "Operating System :: MacOS :: MacOS X",
+    "Programming Language :: Python :: 3.9",
+    "Programming Language :: Python :: 3.10",
+]
+dependencies= [
+    "typing_extensions",
+    "pyarrow",
+    "pandas",
+    "anndata>=0.8",
+    "numpy",
+    "cell_census==0.10.0",
+    "scipy",
+    "fsspec",
+    "s3fs",
+    "requests",
+    "aiohttp",
+    "Cython", # required by owlready2
+    "wheel",  # required by owlready2
+    "owlready2",
+    "gitpython",
+    "attrs>=22.2.0",
+    "psutil",
+    "pyyaml",
+]
+
+[tool.setuptools.packages.find]
+where = ["src"]
+include = ["cell_census_builder*"]  # package names should match these glob patterns (["*"] by default)
+exclude = ["tests*"]  # exclude packages matching these glob patterns (empty by default)
+
+[tool.setuptools_scm]
+root = "../.."
+
+[tool.black]
+line-length = 120
+target_version = ['py39']
+
+[tool.mypy]
+show_error_codes = true
+ignore_missing_imports = true
+warn_unreachable = true
+strict = true
+plugins = "numpy.typing.mypy_plugin"
+
+[tool.ruff]
+select = ["E", "F", "B", "I"]
+ignore = ["E501", "E402", "C408", ]
+line-length = 120
+target-version = "py39"

tools/cell_census_builder/src/cell_census_builder/__init__.py

@@ -0,0 +1,12 @@
+try:
+    from importlib import metadata
+except ImportError:
+    # for python <=3.7
+    import importlib_metadata as metadata  # type: ignore[no-redef]
+
+
+try:
+    __version__ = metadata.version("cell_census_builder")
+except metadata.PackageNotFoundError:
+    # package is not installed
+    __version__ = "0.0.0-unknown"