Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Python package dependency to tiledbsoma 1.1.1 #287

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

bkmartinjr
Copy link
Contributor

Changes:

  • Python package dependency for cell_census is updated to tiledbsoma==1.1.1
  • Regenerate the notebooks

Fixes #269

NOTE: this updates the cell_census package, but not the cell_census_builder package. The builder will lag to provide ongoing data format compatibility with users who are using tiledbsoma 1.0.0 via cell_census 0.10.0. The builder will be upgraded at a later date.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #287 (a5ba4d6) into main (a7fe826) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files          41       41           
  Lines        2223     2223           
=======================================
  Hits         2034     2034           
  Misses        189      189           
Flag Coverage Δ
unittests 91.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bkmartinjr bkmartinjr marked this pull request as ready for review March 24, 2023 18:42
Copy link
Collaborator

@atolopko-czi atolopko-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm assuming notebooks are fine by virtue of them running to completion.

@bkmartinjr
Copy link
Contributor Author

LGTM, though I'm assuming notebooks are fine by virtue of them running to completion.

I was planning on waiting for Pablo to review, to cover this contingency.

Copy link
Contributor

@pablo-gar pablo-gar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I did a pass of the notebooks and everything looks in place

@bkmartinjr bkmartinjr merged commit 7805203 into main Mar 24, 2023
@bkmartinjr bkmartinjr deleted the bkmartinjr/update-tiledbsoma-version branch March 24, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] Update to tiledbsoma 1.1.1
4 participants