Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miscellaneous builder fixes / cleanup #298

Merged
merged 6 commits into from
Mar 27, 2023

Conversation

bkmartinjr
Copy link
Contributor

@bkmartinjr bkmartinjr commented Mar 27, 2023

Various builder fixes to resolve issues found during a test build:

  • update to breaking changes in the Discovery REST API
  • fix typos in Makefile used for manual build
  • update the version used in the Docker image to match that used in package version (i.e., git describe)

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #298 (0f30ba4) into main (79c6240) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files          41       41           
  Lines        2260     2260           
=======================================
  Hits         2069     2069           
  Misses        191      191           
Flag Coverage Δ
unittests 91.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...der/src/cell_census_builder/build_soma/manifest.py 98.61% <100.00%> (ø)
tools/cell_census_builder/tests/test_manifest.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bkmartinjr bkmartinjr marked this pull request as ready for review March 27, 2023 19:46
@bkmartinjr bkmartinjr changed the title miscellaneous builder fixes miscellaneous builder fixes / cleanup Mar 27, 2023
@bkmartinjr bkmartinjr self-assigned this Mar 27, 2023
@bkmartinjr bkmartinjr merged commit a927f72 into main Mar 27, 2023
@bkmartinjr bkmartinjr deleted the bkmartinjr/cleanup-builder-build branch March 27, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants