Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

name migration for tools/builder #340

Merged
merged 6 commits into from
Mar 31, 2023
Merged

name migration for tools/builder #340

merged 6 commits into from
Mar 31, 2023

Conversation

bkmartinjr
Copy link
Contributor

@bkmartinjr bkmartinjr commented Mar 31, 2023 •
edited
Loading

Changes:

  • file and directory name changes: cell_census* -> cellxgene_census*
  • rename package to cellxgene_census_builder
  • internal naming cleanup along the same lines

Note to reviewers: the cellxgene_census_builder intentionally imports the old cell_census package because it wants to pull in an older version of tiledb, for format compatibility with old cell_census releases. Over time, when we are ready to move to a more recent TileDB encoding version, this will migrate to importing cellxgene_census.

ebezzi
ebezzi approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@ebezzi ebezzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkmartinjr bkmartinjr self-assigned this Mar 31, 2023
@bkmartinjr bkmartinjr marked this pull request as ready for review March 31, 2023 20:31
@bkmartinjr bkmartinjr merged commit 284a4a4 into main Mar 31, 2023
@bkmartinjr bkmartinjr deleted the bkmartinjr/tools-name-changes branch March 31, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebezzi ebezzi ebezzi approved these changes

@atolopko-czi atolopko-czi Awaiting requested review from atolopko-czi

Assignees

@bkmartinjr bkmartinjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkmartinjr @ebezzi