[r] use new SOMATileDBContext$context() accessor #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf. single-cell-data/TileDB-SOMA@8691ce0 also incidentally fix deferred FIXME regarding UTF-8 error in value_filter
atolopko-czi
reviewed
Apr 5, 2023
| @@ -1,6 +1,6 @@ | |||
| # A known-good Cell Census version. This may need updating if the version used | |||
| # is withdrawn for any reason. | |||
| KNOWN_CENSUS_VERSION <- "2023-02-13" | |||
| KNOWN_CENSUS_VERSION <- "2023-04-04" | |||
There was a problem hiding this comment.
Ah! This will be less of a problem once have a LTS (5 year) release.
There was a problem hiding this comment.
Why not just designate one build to be a "long term test build", give it a tag, and not delete it? I don't think we need a "real" LTS release for this purpose....
bkmartinjr
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. single-cell-data/TileDB-SOMA@8691ce0
also incidentally fix deferred FIXME regarding UTF-8 error in value_filter