Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration vignette #406

Closed
wants to merge 8 commits into from
Closed

Conversation

pablo-gar
Copy link
Contributor

@pablo-gar pablo-gar commented Apr 21, 2023

partially addresses #248

preview: https://rpubs.com/pablo-gar/1060914

@pablo-gar pablo-gar requested review from mlin and ebezzi April 21, 2023 22:25
@pablo-gar pablo-gar changed the title Pablo gar/add integration vignette Add integration vignette Apr 21, 2023
@mlin
Copy link
Contributor

mlin commented Apr 28, 2023

@pablo-gar Hmm I swear I left a comment here earlier this week, evidently not sorry! I suspect the new vignette is using too much memory for the GitHub Actions worker (which has only 7GB RAM). Do you have any feel for what it uses locally?

We can either scale down the problem size in the vignette to use less memory, or forego building this one as part of the CI workflow. (I don't think we build the Python notebooks in CI, do we?) WDYT?

@mlin
Copy link
Contributor

mlin commented May 12, 2023

@pablo-gar just following up, is https://github.com/single-cell-data/TileDB-SOMA/pull/1274/files maybe going to be helpful for this?

Copy link
Contributor

@mlin mlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it locally, looks great! We'll need to move the file around depending which way we decide to go on #583, but we can handle that in either order easily.

@pablo-gar
Copy link
Contributor Author

Merged via #583

@pablo-gar pablo-gar closed this Aug 2, 2023
@pablo-gar pablo-gar deleted the pablo-gar/add_integration_vignette branch September 12, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants