-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration vignette #406
Conversation
@pablo-gar Hmm I swear I left a comment here earlier this week, evidently not sorry! I suspect the new vignette is using too much memory for the GitHub Actions worker (which has only 7GB RAM). Do you have any feel for what it uses locally? We can either scale down the problem size in the vignette to use less memory, or forego building this one as part of the CI workflow. (I don't think we build the Python notebooks in CI, do we?) WDYT? |
@pablo-gar just following up, is https://github.com/single-cell-data/TileDB-SOMA/pull/1274/files maybe going to be helpful for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran it locally, looks great! We'll need to move the file around depending which way we decide to go on #583, but we can handle that in either order easily.
Merged via #583 |
partially addresses #248
preview: https://rpubs.com/pablo-gar/1060914