Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Census link to docpage navbar #408

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Apr 24, 2023

Fixes #403

Example: https://cellxgene-census.readthedocs.io/en/ebezzi-readthedocs/

Do not merge until Thursday Apr 27

@ebezzi ebezzi requested review from tihuan and pablo-gar April 24, 2023 13:21
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #408 (18bdba5) into main (56c92f4) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   88.55%   88.35%   -0.21%     
==========================================
  Files          50       50              
  Lines        2727     2730       +3     
==========================================
- Hits         2415     2412       -3     
- Misses        312      318       +6     
Flag Coverage Δ
unittests 88.35% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@pablo-gar
Copy link
Contributor

Can we please time this with the Prod release in the main page?

@ebezzi ebezzi changed the title Add Census link to docpage navbar [do not merge] Add Census link to docpage navbar Apr 24, 2023
@ebezzi ebezzi changed the title [do not merge] Add Census link to docpage navbar Add Census link to docpage navbar Apr 27, 2023
@pablo-gar pablo-gar merged commit 59b555a into main Apr 27, 2023
@pablo-gar pablo-gar deleted the ebezzi/census-link-navbar branch April 27, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In readthedocs add "Census" nav bar link as it appears in the cellxgene.cziscience.com
3 participants