Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable route for release.json #409

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Apr 24, 2023

Fixes #400

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #409 (17d84fe) into main (5f5deac) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   88.35%   88.35%           
=======================================
  Files          50       50           
  Lines        2730     2730           
=======================================
  Hits         2412     2412           
  Misses        318      318           
Flag Coverage Δ
unittests 88.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._census/src/cellxgene_census/_release_directory.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@atolopko-czi atolopko-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't realize the endpoint was already set up, but it worked for me, so 🎉 !

(Could remove ", formatted as a CensusDirectory" in the Python comment , since that seems wrong)

@ebezzi ebezzi merged commit e4de56e into main Apr 25, 2023
@ebezzi ebezzi deleted the ebezzi/stable-route-for-release-json branch April 25, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out a strategy for release.json
3 participants