Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin builder dependencies #594

Merged
merged 1 commit into from
Jul 1, 2023
Merged

pin builder dependencies #594

merged 1 commit into from
Jul 1, 2023

Conversation

bkmartinjr
Copy link
Contributor

@bkmartinjr bkmartinjr commented Jun 30, 2023

Fixes #581
Fixes #418

Pin all builder dependencies (excluding two system packages where there is little value).

This ensures that we use the same package versions for test (GHA and manual) and the docker image.

@bkmartinjr bkmartinjr marked this pull request as ready for review June 30, 2023 19:33
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #594 (acce863) into main (c2963f3) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   87.99%   88.10%   +0.10%     
==========================================
  Files          62       62              
  Lines        3741     3741              
==========================================
+ Hits         3292     3296       +4     
+ Misses        449      445       -4     
Flag Coverage Δ
unittests 88.10% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pablo-gar
Copy link
Contributor

Also fixes #418

Copy link
Collaborator

@atolopko-czi atolopko-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkmartinjr bkmartinjr merged commit 4da2f5d into main Jul 1, 2023
@bkmartinjr bkmartinjr deleted the bkmartinjr/builder-pins branch July 1, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[builder] all python dependencies should be pinned Bump builder tiledbsoma version
3 participants