Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] hotfix for release directory JSON parsing problem #649

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

mlin
Copy link
Contributor

@mlin mlin commented Jul 26, 2023

Our way of converting the release directory JSON to a convenient data frame was too brittle for this week's updated release_directory.json (adding the do_not_delete attribute). Fix this by switching from rbind to the more flexible dplyr::bind_rows. (Our package already transitively depended on dplyr via Seurat and others.)

@mlin mlin requested review from ebezzi and pablo-gar July 26, 2023 09:50
@mlin
Copy link
Contributor Author

mlin commented Jul 26, 2023

@pablo-gar @ebezzi FYI- this is somewhat urgent

Copy link
Member

@ebezzi ebezzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike

@mlin mlin merged commit 6065e1d into main Jul 26, 2023
1 check passed
@mlin mlin deleted the mlin/r-hotfix-release-directory-parsing branch July 26, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants