-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch docsite version number from git tags #675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this assume that the git tag is the correct version for all docs? I was under the impression @pablo-gar was still trying to decide if he wants one version or multiple versions.
Approving on the assumption that this decision has been taken, as code looks good.
The current docsite setup doesn't allow for multiple version. We'd need to switch back to readthedocs or use a sphinx plugin for that. This PR merely ensures that no "dev" tags will be added to the version number in the docsite when we build it from main. |
I meant different versions for Python & R packages, and perhaps even another for data docs. But I take your point that this is a problem for another day! |
Codecov Report
@@ Coverage Diff @@
## main #675 +/- ##
=======================================
Coverage 87.06% 87.06%
=======================================
Files 65 65
Lines 4493 4493
=======================================
Hits 3912 3912
Misses 581 581
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Is there an associated issue to link to?
Python and R will have mirrored versions. Data docs are currently not versioned (which we either need to do or make a good effort to create good changelogs) |
Instead of getting the version from the (local) census version, just get the most recent tag from git. This will match the latest released version.