Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit r vignettes #686

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Audit r vignettes #686

merged 5 commits into from
Aug 4, 2023

Conversation

pablo-gar
Copy link
Contributor

Addresses #683

@pablo-gar pablo-gar requested a review from mlin August 3, 2023 23:23
@pablo-gar pablo-gar marked this pull request as ready for review August 3, 2023 23:23
Copy link
Contributor

@mlin mlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo minor comments inline

@@ -40,7 +40,8 @@ Contents
The `cellxgene.census` R package contains a convenient API to open any version of the Census (by default, the newest stable version).

```{r}
census <- cellxgene.census::open_soma()
library("cellxgene.census")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly about this, but the quotes aren't required and not usually used IME. (Throughout)

Suggested change
library("cellxgene.census")
library(cellxgene.census)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's been a shift. Mainly because if the package is not installed you get an variable not found error instead of a package not installed error

api/r/cellxgene.census/vignettes_/census_datasets.Rmd Outdated Show resolved Hide resolved
api/r/cellxgene.census/vignettes_/census_datasets.Rmd Outdated Show resolved Hide resolved
@pablo-gar pablo-gar mentioned this pull request Aug 4, 2023
10 tasks
@pablo-gar pablo-gar merged commit 3a2c836 into main Aug 4, 2023
1 check passed
@pablo-gar pablo-gar deleted the pablo-gar/audit-r-vignettes branch August 4, 2023 18:22
@pablo-gar pablo-gar mentioned this pull request Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants