-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit r vignettes #686
Audit r vignettes #686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo minor comments inline
@@ -40,7 +40,8 @@ Contents | |||
The `cellxgene.census` R package contains a convenient API to open any version of the Census (by default, the newest stable version). | |||
|
|||
```{r} | |||
census <- cellxgene.census::open_soma() | |||
library("cellxgene.census") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel strongly about this, but the quotes aren't required and not usually used IME. (Throughout)
library("cellxgene.census") | |
library(cellxgene.census) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's been a shift. Mainly because if the package is not installed you get an variable not found error instead of a package not installed error
api/r/cellxgene.census/vignettes_/comp_bio_summarize_axis_query.Rmd
Outdated
Show resolved
Hide resolved
api/r/cellxgene.census/vignettes_/comp_bio_summarize_axis_query.Rmd
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Lin <[email protected]>
Co-authored-by: Mike Lin <[email protected]>
Co-authored-by: Mike Lin <[email protected]>
Addresses #683