feat: 'native cell' -> 'unknown' on geneformer label_blocklist #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljhegeman
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
=======================================
Coverage 86.01% 86.01%
=======================================
Files 71 71
Lines 5647 5647
=======================================
Hits 4857 4857
Misses 790 790
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@danieljhegeman , I connected this PR to: |
mlin
approved these changes
Mar 4, 2024
ebezzi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1019
Schema 5.0 will use an updated ontology that does not include
CL:0000003 - native cell. We will accept instead"unknown"for thecell_type_ontology_term_id, and accordingly we will annotatecell_type(label) as"unknown".This should (probably) be merged once we migrate. @mlin let me know if you foresee any issues.