Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test to ensure all supported ontologies are supported by COG API #236

Merged
merged 19 commits into from
Oct 23, 2024

Conversation

nayib-jose-gloria
Copy link
Collaborator

@nayib-jose-gloria nayib-jose-gloria commented Oct 23, 2024

Reason for Change

  • noticed during experimental validator work that after adding new ontologies to the builder, there was no integration test that ensured the corresponding dataclass in the COG API had the new ontologies added. If we miss doing so, we won't be able to query the new assets

Changes

  • add test for Ontology entity class

Note to Reviewers

  • I'm also open to the idea of getting deprecating this enum altogether now that we anticipate it'll change more often to avoid so much redundant work to make additions. But since the API and asset builder are technically separate entities it probably does make sense to maintain this list in both.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (2e1a834) to head (21d513b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   88.95%   89.02%   +0.07%     
==========================================
  Files          18       19       +1     
  Lines        1267     1276       +9     
  Branches      109      111       +2     
==========================================
+ Hits         1127     1136       +9     
  Misses        122      122              
  Partials       18       18              
Flag Coverage Δ
unittests 89.02% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nayib-jose-gloria nayib-jose-gloria marked this pull request as ready for review October 23, 2024 19:30
@nayib-jose-gloria nayib-jose-gloria merged commit 56051f9 into main Oct 23, 2024
12 checks passed
@nayib-jose-gloria nayib-jose-gloria deleted the nayib/test-ontology-entity-drift branch October 23, 2024 20:41
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants