Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CCIE-2509: Update README.md for hvm #3141

Merged
merged 5 commits into from
Mar 11, 2024
Merged

fix: CCIE-2509: Update README.md for hvm #3141

merged 5 commits into from
Mar 11, 2024

Conversation

dspadea
Copy link
Contributor

@dspadea dspadea commented Mar 11, 2024 •
edited by github-actions bot
Loading

CCIE-2509
Summary HVM: Update README.md
Type Task Task
Status In Review

README needs updating:

  • Fix placeholders and install via homebrew if available
  • Restructure for clarity
  • Example commands
  • Mention that Oh-My-ZSH needs to be installed for hooks
  • Other minor tweaks

@dspadea dspadea requested a review from a team as a code owner March 11, 2024 17:17
@dspadea dspadea requested review from alexlokshin-czi, hspitzley-czi and sfitzgerald-czi and removed request for a team March 11, 2024 17:17
@dspadea dspadea enabled auto-merge (squash) March 11, 2024 17:27
@dspadea dspadea merged commit aa97539 into main Mar 11, 2024
31 checks passed
@dspadea dspadea deleted the dspadea/hvm/readme_fixes_2024-03-11-01 branch March 11, 2024 17:38
@czi-github-helper czi-github-helper bot mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlokshin-czi alexlokshin-czi alexlokshin-czi approved these changes

@hspitzley-czi hspitzley-czi Awaiting requested review from hspitzley-czi

@sfitzgerald-czi sfitzgerald-czi Awaiting requested review from sfitzgerald-czi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dspadea @alexlokshin-czi