Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: printing logs when TFE plan fails #3180

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix: printing logs when TFE plan fails #3180

merged 1 commit into from
Mar 27, 2024

Conversation

jakeyheath
Copy link
Contributor

@jakeyheath jakeyheath commented Mar 26, 2024 •
edited by github-actions bot
Loading

CCIE-2592
Summary Happy: Do not print logs when env var HAPPY_SKIP_LOGS=true is set
Type Task Task
Status Done

CCIE-2592

Summary

There is one more place where pod logs are printed. When the TFE plan fails, it was also printing logs.

@jakeyheath jakeyheath requested a review from a team as a code owner March 26, 2024 23:53
@jakeyheath jakeyheath requested review from dtsai-czi and removed request for a team March 26, 2024 23:53
@jakeyheath jakeyheath enabled auto-merge (squash) March 26, 2024 23:59
@jakeyheath jakeyheath merged commit c24adc6 into main Mar 27, 2024
33 of 35 checks passed
@jakeyheath jakeyheath deleted the jakeyheath-patch-11 branch March 27, 2024 00:03
@czi-github-helper czi-github-helper bot mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abiju-czi abiju-czi abiju-czi approved these changes

@dtsai-czi dtsai-czi Awaiting requested review from dtsai-czi dtsai-czi is a code owner automatically assigned from chanzuckerberg/infra-eng-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakeyheath @abiju-czi