Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use patched oidc_cli version #3268

Merged
merged 1 commit into from
May 3, 2024

Conversation

hspitzley-czi
Copy link
Contributor

@hspitzley-czi hspitzley-czi commented May 3, 2024

CCIE-2717
Summary Happy list fails to decompress uncompressed token
Type Bug Bug
Status In Review

https://czi-tech.atlassian.net/browse/CCIE-2717

When an older (uncompressed) token was cached and someone used a new version of the CLI we'd hit this error:

» happy list                                                                                                                                           
[INFO]: Listing stacks from the happy api
[FATAL]: request failed with: failed to get oidc token: failed to get token: Unable to extract token from client: failed to decompress token: failed to create gzip reader: gzip: invalid header

chanzuckerberg/go-misc#1058 - oidc_cli was patched to treat a failure to decompress as a cache miss, refreshing the token

@hspitzley-czi hspitzley-czi requested a review from a team as a code owner May 3, 2024 17:01
@hspitzley-czi hspitzley-czi requested review from netvisao and alexlokshin-czi and removed request for a team May 3, 2024 17:01
Copy link
Contributor

github-actions bot commented May 3, 2024

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

@hspitzley-czi hspitzley-czi enabled auto-merge (squash) May 3, 2024 17:06
@hspitzley-czi hspitzley-czi merged commit 23a19fb into main May 3, 2024
36 of 41 checks passed
@hspitzley-czi hspitzley-czi deleted the hspitzley/fix_unable_to_decompress_token branch May 3, 2024 18:02
@czi-github-helper czi-github-helper bot mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants