[Do not merge] Example of adding hooks to mutation #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2024 10:16
ninabernick
commented
Jul 12, 2024
|
|
||
| after_callback = RegisteredPlatformicsPlugins.getCallback("after", self.type, self.action) | ||
| if after_callback: | ||
| result = after_callback(result, source, info, **kwargs) |
There was a problem hiding this comment.
should before and after callbacks accept the same number of args?
There was a problem hiding this comment.
I think we'd also send the result to the after callbacks so that they can manipulate the result
j-x-han
reviewed
Jul 12, 2024
|
|
||
|
|
||
| @register_plugin("before", "sample", "create") | ||
| def validate_sample_name(source: Any, info: Info, **kwargs: SampleCreateInput) -> None: |
There was a problem hiding this comment.
I think **kwargs might include everything that gets sent to the resolver, so in addition to SampleCreateInput, session, cerbos_client, principal, is_system_user, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of adding hooks to create, update, delete mutations. This example validates the name of a sample before it is created.
Right now a before callback receives three args (inputs to the mutation) and the after callback receives four (inputs to the mutation + the result). This is weird.