Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry schema-migration sfn on Batch.AWSBatchException #7165

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

Bento007
Copy link
Contributor

@Bento007 Bento007 commented Jun 5, 2024

Reason for Change

  • the scheme migration can fail with the error Batch.AWSBatchException. We will now retry when this happens.

Changes

  • add Batch.AWSBatchException to retry logic for schema migration.

- the scheme migration can fail with the error Batch.AWSBatchException. We will now retry when this happens.
- pass error message so they show up in the error handling steps inthe Sfn
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Deployment Summary

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (df9b3e5) to head (6cab9a9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7165   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files         188      188           
  Lines       15733    15733           
=======================================
  Hits        14579    14579           
  Misses       1154     1154           
Flag Coverage Δ
unittests 92.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nayib-jose-gloria nayib-jose-gloria enabled auto-merge (squash) June 6, 2024 14:09
@nayib-jose-gloria nayib-jose-gloria merged commit a6c5645 into main Jun 6, 2024
39 checks passed
@nayib-jose-gloria nayib-jose-gloria deleted the tsmith/retry-sfn branch June 6, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants