Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create Deleted DatasetVersion "Clean up" Job #7315

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

lvreynoso
Copy link
Contributor

Reason for Change

Changes

  • add
  • remove
  • modify

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions
  • For UI changes, verify impacted analytics events still work

Notes for Reviewer

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.87%. Comparing base (0442ec7) to head (c84aa4c).

Files with missing lines Patch % Lines
backend/layers/thirdparty/lambda_provider.py 52.38% 10 Missing ⚠️
backend/layers/processing/process.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7315      +/-   ##
==========================================
- Coverage   92.93%   92.87%   -0.06%     
==========================================
  Files         194      195       +1     
  Lines       16818    16847      +29     
==========================================
+ Hits        15629    15647      +18     
- Misses       1189     1200      +11     
Flag Coverage Δ
unittests 92.87% <66.66%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant