Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: HuBMAP v7 #7361

Merged
merged 5 commits into from
Nov 5, 2024
Merged

chore: HuBMAP v7 #7361

merged 5 commits into from
Nov 5, 2024

Conversation

MillenniumFalconMechanic
Copy link
Collaborator

@MillenniumFalconMechanic MillenniumFalconMechanic commented Oct 10, 2024

Reason for Change

  • #SCE-30

Changes

  • Updated ASCTB master sheet URL.
  • Prevented references without a doi key from being mapped to Reference objects.
  • Updated DOI formats to be cleaned.
  • Added try/catch to swallow and log invalid DOI exceptions.
  • Added back awscli package to allow pipeline output to be uploaded to S3 (accidentally removed here).

Testing steps

  • Manually testing on rdev.
  • Updated clean DOI unit tests.

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (8d24ee0) to head (ffe9125).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7361   +/-   ##
=======================================
  Coverage   92.90%   92.91%           
=======================================
  Files         194      194           
  Lines       16831    16831           
=======================================
+ Hits        15637    15638    +1     
+ Misses       1194     1193    -1     
Flag Coverage Δ
unittests 92.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MillenniumFalconMechanic MillenniumFalconMechanic force-pushed the mim/sce-30-hubmap-v7 branch 3 times, most recently from ef0f081 to b84f033 Compare November 1, 2024 18:51
@MillenniumFalconMechanic MillenniumFalconMechanic marked this pull request as ready for review November 4, 2024 18:15
@MillenniumFalconMechanic MillenniumFalconMechanic merged commit c436039 into main Nov 5, 2024
39 checks passed
@MillenniumFalconMechanic MillenniumFalconMechanic deleted the mim/sce-30-hubmap-v7 branch November 5, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants