Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: seurat deprecation notice (SCE-32) #7365

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Oct 16, 2024

Reason for Change

  • Ticket
  • Notify users of upcoming Seurat deprecation

Changes

  • Add deprecation warning banner
  • Add relevant docs

Testing steps

  • Visual QA for content and design
  • rdev -> here
  • Docs -> here

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions
  • For UI changes, verify impacted analytics events still work

Notes for Reviewer

Screenshot 2024-10-18 at 12 27 04 PM

Copy link
Contributor

Deployment Summary

@kaloster kaloster force-pushed the kaloster/seurat-removal-notice branch from c1ee8e3 to 6e832a9 Compare October 16, 2024 22:40
@kaloster kaloster changed the title chore: add notice for seurat removal chore: add notice for seurat removal (SCE-32) Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (9c87d94) to head (1f25fc0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7365   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files         194      194           
  Lines       16831    16831           
=======================================
  Hits        15637    15637           
  Misses       1194     1194           
Flag Coverage Δ
unittests 92.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaloster kaloster force-pushed the kaloster/seurat-removal-notice branch from 40345ea to e0b16de Compare October 18, 2024 16:14
@kaloster kaloster changed the title chore: add notice for seurat removal (SCE-32) chore: seurat deprecation notice (SCE-32) Oct 18, 2024
@kaloster kaloster force-pushed the kaloster/seurat-removal-notice branch from e0b16de to 4b7bb06 Compare October 18, 2024 16:21
@kaloster kaloster marked this pull request as ready for review October 18, 2024 16:24
@kaloster kaloster force-pushed the kaloster/seurat-removal-notice branch from 27b0e27 to aaa2a59 Compare October 18, 2024 17:19
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HURRAY! THANK YOU!!

@kaloster kaloster merged commit 00b6ae8 into main Oct 21, 2024
39 checks passed
@kaloster kaloster deleted the kaloster/seurat-removal-notice branch October 21, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants